Allow sequence in groupby level #837
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test fail currently, as the level parameter currently does not accept any sequences.
We are doing this for consistency purposes. There are still tests that have to adopt that convention (they are close to 2 years old), but we are using the convention on any new tests that are added. So if you could add the |
Dr-Irv
requested changes
Dec 22, 2023
|
Is it fine like that? |
Dr-Irv
requested changes
Dec 22, 2023
tests/test_frame.py
Outdated
| @@ -1082,7 +1082,10 @@ def test_types_groupby_level() -> None: | |||
| "col4": [1, 2, 3], | |||
| } | |||
| df = pd.DataFrame(data=data).set_index(["col1", "col2", "col3"]) | |||
| df.groupby(level=["col1", "col2"]).sum() | |||
| check( | |||
| assert_type(df.groupby(level=["col1", "col2"]).sum(), "pd.DataFrame"), | |||
There was a problem hiding this comment.
Suggested change
| assert_type(df.groupby(level=["col1", "col2"]).sum(), "pd.DataFrame"), | |
| assert_type(df.groupby(level=["col1", "col2"]).sum(), pd.DataFrame), |
You don't need the quotes here because the type is known at runtime.
There was a problem hiding this comment.
Makes sense, I did the change.
Thanks for the feedback.
| @@ -445,7 +445,11 @@ def test_types_groupby_level() -> None: | |||
| [(0, 0, 1), (0, 1, 2), (0, 0, 3)], names=["col1", "col2", "col3"] | |||
| ) | |||
| s = pd.Series([1, 2, 3], index=index) | |||
| s.groupby(level=["col1", "col2"]).sum() | |||
| check( | |||
| assert_type(s.groupby(level=["col1", "col2"]).sum(), "pd.Series[int]"), | |||
There was a problem hiding this comment.
You do need the quotes here around pd.Series[int], because the generic version is not known at runtime.
twoertwein
pushed a commit
to twoertwein/pandas-stubs
that referenced
this pull request
Dec 24, 2023
* Add test cases for level sequences This test fail currently, as the level parameter currently does not accept any sequences. * Allow sequences for groupby level parameter This fixes pandas-dev#836 * Add assert_type * Remove unnecessary quotes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
assert_type()to assert the type of any return value. I do not really see value in checking any return type here, though?