(r)true/floor div #764
Merged
(r)true/floor div #764
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twoertwein
commented
Aug 14, 2023
Dr-Irv
requested changes
Aug 15, 2023
Dr-Irv
approved these changes
Aug 15, 2023
Dr-Irv
requested changes
Aug 15, 2023
3 tasks
Dr-Irv
requested changes
Aug 16, 2023
tests/test_indexes.py
Outdated
|
|
||
| check(assert_type(delta / index, "pd.Index[float]"), pd.Index, float) | ||
| # ZeroDivisionError | ||
| # check(assert_type([delta] / index, "pd.Index[float]"), pd.Index, float) |
There was a problem hiding this comment.
I think if you did index = pd.Index([pd.Timedelta(days=1)], dtype="timedelta64[s]"), then we wouldn't get the div by zero.
There was a problem hiding this comment.
Thank you, that made it work!
Dr-Irv
reviewed
Aug 16, 2023
tests/test_indexes.py
Outdated
| dtype: type[np.integer] = np.int64 | ||
| if sys.platform == "win32": | ||
| dtype = np.int32 | ||
| check(assert_type([delta] // index, "pd.Index[int]"), pd.Index, dtype) |
There was a problem hiding this comment.
I think you can use np.intp and it will be platform independent. Did you try that?
There was a problem hiding this comment.
There was a problem hiding this comment.
Can you try np.integer ? Both isinstance(np.int32(8), np.integer) and isinstance(np.int64(10), np.integer) are True for me on Windows and Linux.
There was a problem hiding this comment.
Thank you, using np.signedinteger worked as well :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Focused mostly on timedelta.