period_range and Period should accept date, datetime and pd.Timestamp #728
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Dr-Irv looks like this was indeed a documentation issue, I submitted pandas-dev/pandas#53611 and pandas-dev/pandas#53632 to address the issue reported there (pandas-dev/pandas#53038). The first one has been merged, but the solution was incomplete to I submitted the second one (pending review). |
Dr-Irv
requested changes
Jun 13, 2023
pandas-stubs/core/series.pyi
Outdated
| @@ -851,7 +851,7 @@ class Series(IndexOpsMixin, NDFrame, Generic[S1]): | |||
| @overload | |||
| def apply( | |||
| self, | |||
| func: Callable[..., Scalar | Sequence | set | Mapping | None], | |||
| func: Callable[..., Scalar | Sequence | set | Mapping | NAType | None], | |||
There was a problem hiding this comment.
I think this change came up because you haven't merged with main. Can you make sure you have done that?
tests/test_series.py
Outdated
| @@ -470,6 +471,8 @@ def get_depth(url: str) -> int: | |||
| ss = s.astype(str) | |||
| check(assert_type(ss.apply(get_depth), pd.Series), pd.Series, np.int64) | |||
|
|
|||
| check(assert_type(s.apply(lambda x: pd.NA), pd.Series), pd.Series, NAType) | |||
There was a problem hiding this comment.
same comment as above - this change is already in main
tests/test_timefuncs.py
Outdated
Comment on lines
841
to
861
| check( | ||
| assert_type( | ||
| pd.period_range(pd.Timestamp("2001-01-01"), end="2002-01-01", freq="Q"), | ||
| pd.PeriodIndex, | ||
| ), | ||
| pd.PeriodIndex, | ||
| ) | ||
| check( | ||
| assert_type( | ||
| pd.period_range(dt.datetime(2001, 1, 1), end="2002-01-01", freq="Q"), | ||
| pd.PeriodIndex, | ||
| ), | ||
| pd.PeriodIndex, | ||
| ) | ||
| check( | ||
| assert_type( | ||
| pd.period_range(dt.date(2001, 1, 1), end="2002-01-01", freq="Q"), | ||
| pd.PeriodIndex, | ||
| ), | ||
| pd.PeriodIndex, | ||
| ) |
There was a problem hiding this comment.
For these tests, you should also change the end argument to be the corresponding type.
|
Thanks! Just made the changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
period_rangeandPeriodshould acceptdate,datetimeandpd.Timestamp#675 (Replace xxxx with the Github issue number)assert_type()to assert the type of any return value