close out a few first issues #670
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twoertwein
reviewed
May 1, 2023
| @@ -371,7 +371,7 @@ def interval_range( | |||
| start: _TimestampLike, | |||
| end: _TimestampLike = ..., | |||
| periods: int | None = ..., | |||
| freq: str | BaseOffset | None = ..., | |||
| freq: str | BaseOffset | pd.Timedelta | dt.timedelta | None = ..., | |||
There was a problem hiding this comment.
is pd.Timedelta a subclass of datetime.timedelta? Could simplify this union (or keep, if it is more explicit).
There was a problem hiding this comment.
Yes, it is a subclass. We're inconsistent in the stubs. Some places we just say pd.Timedelta, others we have the union. I like the explicit aspect to make it clear that dt.timedelta is accepted.
twoertwein
reviewed
May 1, 2023
| | list[str] | ||
| | slice | ||
| | _IndexSliceTuple | ||
| | Callable, |
There was a problem hiding this comment.
Happy to keep it as is - it is probably not worth to try to enumerate all allowed arguments/return values.
There was a problem hiding this comment.
Yes. We have it this way in DataFrame.loc as well.
|
Thanks @Dr-Irv ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Had a little time so closed out a few "good first issues"
Closes Series.apply() should accept
Noneas Callable return type #557Closes
Series.loc()typecheck fails with a lambda (Callable[[Any], Any]) #586Closes timedelta_range or interval_range should accept Timedelta or timedelta as freq #600
Tests added:
test_series.py: test_apply_returns_none()test_series.py: test_loc_callable()timedelta_range()andinterval_range()withtimedeltaarguments.