Fix result type of DataFrame.align
#577
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twoertwein
reviewed
Mar 15, 2023
pandas-stubs/core/frame.pyi
Outdated
| @@ -558,7 +559,7 @@ class DataFrame(NDFrame, OpsMixin): | |||
| limit: int | None = ..., | |||
| fill_axis: Axis = ..., | |||
| broadcast_axis: Axis | None = ..., | |||
| ) -> DataFrame: ... | |||
| ) -> tuple[DataFrame, _SeriesOrFrameT]: ... | |||
There was a problem hiding this comment.
I believe you can use pandas._typing.NDFreamT instead of creating a new TypeVar.
Can you please also add a quick test?
There was a problem hiding this comment.
Agree to use NDFrameT, because that will give the precise type of Series or DataFrame based on other
Tests should test using other as a DataFrame and other as a Series
twoertwein
pushed a commit
to twoertwein/pandas-stubs
that referenced
this pull request
Apr 1, 2023
* Fix result type of `DataFrame.align` * Use `NDFrameT` instead of newly added `_SeriesOrFrameT` * Add tests for `DataFrame.align`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The result type of
DataFrame.alignshould be a tuple instead ofDataFrame.