-
-
Notifications
You must be signed in to change notification settings - Fork 141
Support an ExtensionDtype and ExtensionArray #554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
4bae5e7
Support an ExtensionDtype and ExtensionArray
Dr-Irv 011af56
Merge remote-tracking branch 'upstream/main' into testextdtype
Dr-Irv 2edb805
update TypeGuard usage. Test astype for Decimal
Dr-Irv fb1c15b
use ClassVar. Change is_float to accept numpy. Remove self: Self
Dr-Irv fb9a7ae
remove declarations of private funcs. make na_value a property
Dr-Irv File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,9 +1,28 @@ | ||
from enum import Enum | ||
from typing import ( | ||
Final, | ||
Literal, | ||
) | ||
|
||
import numpy as np | ||
from pandas import Interval | ||
from typing_extensions import ( | ||
TypeAlias, | ||
TypeGuard, | ||
) | ||
|
||
class _NoDefault(Enum): | ||
no_default = ... | ||
|
||
no_default: Final = _NoDefault.no_default | ||
NoDefault: TypeAlias = Literal[_NoDefault.no_default] | ||
|
||
def infer_dtype(value: object, skipna: bool = ...) -> str: ... | ||
def is_iterator(obj: object) -> bool: ... | ||
def is_scalar(val: object) -> bool: ... | ||
def is_list_like(obj: object, allow_sets: bool = ...) -> bool: ... | ||
def is_interval(val: object) -> bool: ... | ||
def is_complex(val: object) -> bool: ... | ||
def is_bool(val: object) -> bool: ... | ||
def is_integer(val: object) -> bool: ... | ||
def is_float(val: object) -> bool: ... | ||
def is_interval(val: object) -> TypeGuard[Interval]: ... | ||
def is_complex(val: object) -> TypeGuard[complex]: ... | ||
def is_bool(val: object) -> TypeGuard[bool | np.bool_]: ... | ||
def is_integer(val: object) -> TypeGuard[int | np.integer]: ... | ||
def is_float(val: object) -> TypeGuard[float | np.floating]: ... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Empty file.
Empty file.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@twoertwein @Dr-Irv While I understand the intention, this one causes a problem with the following types from Pandas:
pandas.core.frame.DataFrame.reorder_levels(self, order: Sequence[Axis], axis: Axis = 0)
The order parameter expects a sequence of ints or strings - with this change this is forbidden.
From my code:
PS: Sorry for not creating an issue (yet). I am short on time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When you do have the time, please create an issue with a full code sample.
This has picked up that
reorder_levels()
has an incorrect type fororder
. It should beSequence[Hashable]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here we go: #560