Change check() function to test actual types in Series and Index #546
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twoertwein
reviewed
Feb 20, 2023
twoertwein
approved these changes
Feb 20, 2023
Unfortunately not! It was a bit of wack-a-mole.
Agreed, but I think we should be doing this level of checking when we get to things like |
|
Thanks @Dr-Irv ! btw, the next mypy release (1.1?) will suggest using pandas-stubs python/mypy#14328 (comment) |
twoertwein
pushed a commit
to twoertwein/pandas-stubs
that referenced
this pull request
Apr 1, 2023
…das-dev#546) * fix check function to check actual type, not using __iter__() * change np.int32 to np.int_ * for bitwise use np.integer * change tables reference in pyproject.toml * for nightly, use np.integer rather than np.int64 * make timedelta division type result dependent on pandas version * fix mypy issue of assigning timedeltadiv return type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While reviewing #372 , it uncovered that by having
check()usenext(iter()), if you have aSeries([1,2,3], dtype=np.int8), it was not checking that the actual type of the first element wasnp.int8, sinceSeries.__iter__()returns a python scalar.So this corrects that, allowing us to be more precise in the type checking of the values inside the results, since we want to check that
astype()is doing what we expect.Also, was able to allow
pytablesto work with 3.11, since they released a compatible version.Uncovered an odd issue with bitwise operations on lists of
intIn some cases, used
np.integerbecause it is a supertype that works across platforms. Other times,np.int_worked fine.