Fix __getitem__() for various index types #537
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
start_time
andend_time
attributes raise error #536test_indexes.py:test_getitem()
By making
__getitem__()
a mixin, it uncovered some odd hierarchy in the index types, where we had redundant declarations, and some incorrect detection of some invalid subtraction operations. So the changes here make the original tests pass, and then we can test__getitem__()
on various index types.Was able to get rid of a number of
#type: ignore
statements as a result.Either @bashtage or @twoertwein can review/approve.