fix NumericIndex for nightly #528
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twoertwein
reviewed
Feb 7, 2023
tests/test_indexes.py
Outdated
| if not PD_LTE_15: | ||
| from typing_extensions import TypeAlias | ||
|
|
||
| NumericIndex: TypeAlias = pd.Index |
There was a problem hiding this comment.
from pandas import Index as NumericIndex could be slightly simpler
There was a problem hiding this comment.
Good idea. Fixed in commit 600ab56
twoertwein
approved these changes
Feb 7, 2023
|
Thanks @Dr-Irv |
twoertwein
pushed a commit
to twoertwein/pandas-stubs
that referenced
this pull request
Apr 1, 2023
* fix NumericIndex for nightly * import Index as NumericIndex
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nightly builds were failing because
NumericIndexis removed for 2.0, so this allows it to work for 1.5.x, but removes it from testing for 2.0.Once 2.0 is released, then we can remove
NumericIndexin the PYI and tests.