remove np.datetime64 from S1, make adding two TimestampSeries fail #527
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twoertwein
reviewed
Feb 7, 2023
| c_series_dt64: pd.Series[np.datetime64] = pd.Series( | ||
| [1, 2, 3], dtype="datetime64[ns]" | ||
| ) | ||
| c_series_dt64: TimestampSeries = pd.Series([1, 2, 3], dtype="datetime64[ns]") |
There was a problem hiding this comment.
Is it possible to specify dtype=np.datetime64?
There was a problem hiding this comment.
No. This is consistent with numpy.
>>> import pandas as pd
>>> import numpy as np
>>> pd.Series([1,2,3], dtype=np.datetime64)
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "C:\Anaconda3\envs\pandasstubs\lib\site-packages\pandas\core\series.py", line 470, in __init__
data = sanitize_array(data, index, dtype, copy)
File "C:\Anaconda3\envs\pandasstubs\lib\site-packages\pandas\core\construction.py", line 622, in sanitize_array
subarr = _try_cast(data, dtype, copy, raise_cast_failure)
File "C:\Anaconda3\envs\pandasstubs\lib\site-packages\pandas\core\construction.py", line 827, in _try_cast
return maybe_cast_to_datetime(arr, dtype)
File "C:\Anaconda3\envs\pandasstubs\lib\site-packages\pandas\core\dtypes\cast.py", line 1321, in maybe_cast_to_datetime
dtype = _ensure_nanosecond_dtype(dtype)
File "C:\Anaconda3\envs\pandasstubs\lib\site-packages\pandas\core\dtypes\cast.py", line 1468, in _ensure_nanosecond_dtype
raise ValueError(msg)
ValueError: The 'datetime64' dtype has no unit. Please pass in 'datetime64[ns]' instead.
twoertwein
approved these changes
Feb 7, 2023
|
Thanks @Dr-Irv |
twoertwein
pushed a commit
to twoertwein/pandas-stubs
that referenced
this pull request
Apr 1, 2023
…andas-dev#527) remove np.datetime64 from S1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out that it is not possible to have a
Seriescontainingnp.datetime64types - they get converted toTimestamp. Discovered this with some experiments that showed we were allowing twoSeriesofTimestampto be added, which is not possible, so fixed that as well.