allow callable in .loc #509
Conversation
| @@ -157,6 +157,7 @@ class _LocIndexerFrame(_LocIndexer): | |||
| self, | |||
| idx: IndexType | |||
| | MaskType | |||
| | Callable[[DataFrame], IndexType | MaskType | list[HashableT]] | |||
There was a problem hiding this comment.
Does pandas support callables for both index and columns? Might need to also add it to the tuple format.
There was a problem hiding this comment.
Does pandas support callables for both index and columns? Might need to also add it to the tuple format.
Yes. Question is whether I try to get this right now (and create some tests), or wait for a bug report. If you think I should add it now, let me know and I'll give it a shot.
There was a problem hiding this comment.
I'm fine adding annotations as needed :) Only popped out because in one place a plain Callable is used and in the other place the argument/return type is specified.
There was a problem hiding this comment.
Happy to merge after the conflict with main is resolved
There was a problem hiding this comment.
should be done in fdf4e03
There was a problem hiding this comment.
I'm fine adding annotations as needed :) Only popped out because in one place a plain Callable is used and in the other place the argument/return type is specified.
Yes, I saw that and decided not to try to fix it. The other issue is that we match on a Hashable and any Callable works there too.
|
Thanks @Dr-Irv ! |
.loc[]#256test_frame.py:test_loc_callback()This handles the original issue, and some examples that came up during the discussion in the issue, but may not handle all the cases where a
Callablecan be used in.loc. Can always enhance based on further user reports.