Skip to content

Remove use of Never #506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 14, 2023
Merged

Remove use of Never #506

merged 1 commit into from
Jan 14, 2023

Conversation

Dr-Irv
Copy link
Collaborator

@Dr-Irv Dr-Irv commented Jan 11, 2023

Turns out that I misunderstood the use of Never, and we don't need to use it. See #441 (comment) .

@Dr-Irv Dr-Irv requested a review from bashtage January 11, 2023 20:36
Copy link
Member

@twoertwein twoertwein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice clean up :) Happy to merge unless you want a second review.

@Dr-Irv
Copy link
Collaborator Author

Dr-Irv commented Jan 11, 2023

Nice clean up :) Happy to merge unless you want a second review.

Let's give @bashtage a day to review, since I modified code from a previous PR of his. If he doesn't respond, then go ahead and merge.

@twoertwein twoertwein merged commit 48caaff into pandas-dev:main Jan 14, 2023
@twoertwein
Copy link
Member

Thanks @Dr-Irv !

@Dr-Irv Dr-Irv deleted the fixnever branch February 4, 2023 17:03
twoertwein pushed a commit to twoertwein/pandas-stubs that referenced this pull request Apr 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FEATURE: Start using Never as return types for disallowed operations
2 participants