allow multiindex for a column in DataFrame.loc #494
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dr-Irv
changed the title
twoertwein
reviewed
Jan 3, 2023
pandas-stubs/core/frame.pyi
Outdated
| @@ -166,7 +166,9 @@ class _LocIndexerFrame(_LocIndexer): | |||
| @overload | |||
| def __getitem__( | |||
| self, | |||
| idx: tuple[int | StrLike | tuple[ScalarT, ...], int | StrLike], | |||
| idx: tuple[ | |||
| int | StrLike | tuple[ScalarT, ...], int | StrLike | tuple[ScalarT, ...] | |||
There was a problem hiding this comment.
Would Scalar also work here instead of ScalarT?
There was a problem hiding this comment.
Would
Scalaralso work here instead ofScalarT?
Yes, seems so. Fixed in commit 3417725
twoertwein
reviewed
Jan 3, 2023
pandas-stubs/core/indexing.pyi
Outdated
| @@ -15,7 +15,7 @@ from pandas._typing import ( | |||
| ) | |||
|
|
|||
| _IndexSliceTuple: TypeAlias = tuple[ | |||
| Union[Index, MaskType, Scalar, list[ScalarT], slice], ... | |||
| Union[Index, MaskType, Scalar, list[ScalarT], slice | tuple[ScalarT, ...]], ... | |||
There was a problem hiding this comment.
Same here (I think we need it for list but not sure about tuple).
There was a problem hiding this comment.
Same here (I think we need it for
listbut not sure abouttuple).
Yes, fixed in commit 3417725
twoertwein
reviewed
Jan 3, 2023
pandas-stubs/core/series.pyi
Outdated
| index: Axes | None = ..., | ||
| dtype=..., | ||
| name: Hashable | None = ..., | ||
| copy: bool = ..., | ||
| fastpath: bool = ..., | ||
| ) -> Series[IntervalT]: ... | ||
| ) -> Series[Interval[int]]: ... | ||
| @overload |
There was a problem hiding this comment.
would be nice to add the TODO again
There was a problem hiding this comment.
Same issue - included the changes from the other PR, so I've reverted that here in commit fb51203
twoertwein
approved these changes
Jan 3, 2023
|
Thanks @Dr-Irv ! |
twoertwein
pushed a commit
to twoertwein/pandas-stubs
that referenced
this pull request
Apr 1, 2023
* split Series[IntervalT] into separate __new__ * allow multiindex for a colun in DataFrame.loc * revert changes related to Series.__new__ and IntervalT * change tuple[ScalarT,...] to tuple[Scalar, ...]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pandas.DataFrame.locwith atuple[str, str]multi-index seems to elicitmypyerrors #466test_frame.py:test_getsetitem_multiindex()