Skip to content

added list[Levels] to Dataframe.stack() #491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 5, 2023
Merged

added list[Levels] to Dataframe.stack() #491

merged 2 commits into from
Jan 5, 2023

Conversation

muddi900
Copy link
Contributor

@muddi900 muddi900 commented Dec 31, 2022 •
edited
Loading

Dr-Irv
Dr-Irv requested changes Jan 2, 2023
View reviewed changes
Copy link
Collaborator

@Dr-Irv Dr-Irv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add a test corresponding to the code from the issue, and also an example that tests a single level?

Dr-Irv
Dr-Irv requested changes Jan 3, 2023
View reviewed changes
Dr-Irv
Dr-Irv requested changes Jan 3, 2023
View reviewed changes
Copy link
Collaborator

@Dr-Irv Dr-Irv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on this: https://github.com/pandas-dev/pandas-stubs/actions/runs/3831371047/jobs/6520515609

you need to run the pre-commit action to format the files.

If you do poetry run poe style, that should fix the issue.

@muddi900
added list[Levels] as per pandas-dev#489 and added appropriate tests
0620024 
added a generic Any for series output

created tests for stack

wrapping generics in quotes for compatibility

style update
@Dr-Irv
Copy link
Collaborator

Dr-Irv commented Jan 4, 2023

@muddi900 It turns out that we had an issue with our CI due to a SQLAlchemy update. This was just fixed in #496.

Can you merge with upstream/main and push, and ping here so I can trigger the tests? Code looks good at this point, so just need it to pass our CI.

Dr-Irv
Dr-Irv approved these changes Jan 5, 2023
View reviewed changes
Copy link
Collaborator

@Dr-Irv Dr-Irv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @muddi900

@Dr-Irv Dr-Irv merged commit af4102f into pandas-dev:main Jan 5, 2023
@muddi900 muddi900 deleted the level-list branch January 5, 2023 16:23
twoertwein pushed a commit to twoertwein/pandas-stubs that referenced this pull request Apr 1, 2023
@muddi900 @twoertwein
added list[Levels] to Dataframe.stack() (pandas-dev#491)
8206acc 
added list[Levels] as per pandas-dev#489 and added appropriate tests

added a generic Any for series output

created tests for stack

wrapping generics in quotes for compatibility

style update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dr-Irv Dr-Irv Dr-Irv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DataFrame.stack() needs to accept list for level argument
2 participants
@muddi900 @Dr-Irv