Skip to content

TYP: fix almost all keyword-only reported by stubtest #474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Dec 23, 2022

Conversation

twoertwein
Copy link
Member

@twoertwein twoertwein commented Dec 18, 2022

Ran poe stubtest --nightly | grep keyword-only

Not sure about the cases with

Not actually positional-only, used to handle deprecations in 1.5.0

Currently fails because of python/mypy#14311 (edit: I duplicated the overloads to avoid the mypy bug for now)

@gandhis1
Copy link
Contributor

Sometimes keyword-only arguments are used when they are not actually such because that is the only way to handle some literal overloads: python/mypy#5486

I'm surprised the tests pass after removing some of these.

@twoertwein twoertwein marked this pull request as ready for review December 19, 2022 15:13
@twoertwein twoertwein requested a review from Dr-Irv December 19, 2022 15:16
Copy link
Collaborator

@Dr-Irv Dr-Irv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not entirely sure how we test all these kinds of changes, but I checked that what you did matches the docs.

Copy link
Collaborator

@Dr-Irv Dr-Irv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remaining two issues are to put back the args in Timestamp.__new__() and delete __init__() from Resampler and BaseGroupBy

@twoertwein twoertwein requested a review from Dr-Irv December 20, 2022 18:31
Copy link
Collaborator

@Dr-Irv Dr-Irv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @twoertwein

@Dr-Irv Dr-Irv merged commit 2339f31 into pandas-dev:main Dec 23, 2022
@twoertwein twoertwein deleted the stubtest branch February 10, 2024 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants