-
-
Notifications
You must be signed in to change notification settings - Fork 141
TYP: fix almost all keyword-only reported by stubtest #474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Sometimes keyword-only arguments are used when they are not actually such because that is the only way to handle some literal overloads: python/mypy#5486 I'm surprised the tests pass after removing some of these. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not entirely sure how we test all these kinds of changes, but I checked that what you did matches the docs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remaining two issues are to put back the args in Timestamp.__new__()
and delete __init__()
from Resampler
and BaseGroupBy
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @twoertwein
Ran
poe stubtest --nightly | grep keyword-only
Not sure about the cases with
Currently fails because of python/mypy#14311 (edit: I duplicated the overloads to avoid the mypy bug for now)