Skip to content

gh-460: added 'TimestampSeries' in TimedeltaSeries in series.pyi #464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 12, 2022
Merged

gh-460: added 'TimestampSeries' in TimedeltaSeries in series.pyi #464

merged 4 commits into from
Dec 12, 2022

Conversation

ramvikrams
Copy link
Contributor

@ramvikrams ramvikrams changed the title #460: added 'TimestampSeries' in TimedeltaSeries in series.pyi gh-460: added 'TimestampSeries' in TimedeltaSeries in series.pyi Dec 9, 2022
Dr-Irv
Dr-Irv requested changes Dec 9, 2022
View reviewed changes
tests/test_timefuncs.py Outdated
tds = pd.Series(pd.timedelta_range(start="1 day", periods=10))
tss = pd.Series(pd.date_range(start="2012-01-01", periods=10, freq="W-MON"))
plus = tds + tss
check(assert_type(plus, "TimestampSeries"), pd.Series)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add pd.Timestamp as the last argument to check

Also change name to test_timedeltaseries_add_timestampseries

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes i'll do that

Dr-Irv
Dr-Irv reviewed Dec 9, 2022
View reviewed changes
Copy link
Collaborator

@Dr-Irv Dr-Irv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks good, but the CI failures on MacOS are something we need to investigate.

@ramvikrams
Copy link
Contributor Author

Yeah I'll look into it

@ramvikrams
Copy link
Contributor Author

ramvikrams commented Dec 10, 2022 •
edited
Loading

Sir I looked into it, it fails because of this Failed to install /Users/runner/Library/Caches/pypoetry/artifacts/59/74/28/0da99c4265a039049b4cccc0a54b5103991e1d78c7d85b899291d627c5/black-22.10.0-1fixedarch-cp310-cp310-macosx_11_0_x86_64.whl, I think it is not able to install but why?, that is what I am not able to understand

@Dr-Irv
Copy link
Collaborator

Dr-Irv commented Dec 11, 2022

I think it is not able to install but why?, that is what I am not able to understand

We are not sure. I Just did a PR and those jobs had no issue, and there is nothing you changed that would cause them to fail. May have been a momentary hiccup in the CI.

@ramvikrams
Copy link
Contributor Author

ramvikrams commented Dec 11, 2022 •
edited
Loading

The same tests are failing again we have this ERROR: black-22.10.0-1fixedarch-cp39-cp39-macosx_11_0_x86_64.whl is not a supported wheel on this platform. in the CI so is it some version issue

@Dr-Irv
Copy link
Collaborator

Dr-Irv commented Dec 11, 2022

Can you try this? Modify pyproject.toml on the line about the black version and change it to:

black = ">=22.12.0"

then commit and push.

@ramvikrams
Copy link
Contributor Author

Can you try this? Modify pyproject.toml on the line about the black version and change it to:

black = ">=22.12.0"

then commit and push.

yeah

@ramvikrams
Copy link
Contributor Author

All these tests fail but in my local test poe test succeds

@Dr-Irv
Copy link
Collaborator

Dr-Irv commented Dec 11, 2022

That was a separate issue that I did a PR for on Friday, and just merged it. Do git fetch upstream then git merge upstream/main then push, and I think we'll be good.

@ramvikrams
Copy link
Contributor Author

That was a separate issue that I did a PR for on Friday, and just merged it. Do git fetch upstream then git merge upstream/main then push, and I think we'll be good.

yes

@ramvikrams
Copy link
Contributor Author

Done sir, it finishes off nicely

Dr-Irv
Dr-Irv approved these changes Dec 12, 2022
View reviewed changes
Copy link
Collaborator

@Dr-Irv Dr-Irv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @ramvikrams

@Dr-Irv Dr-Irv merged commit 52f8ebd into pandas-dev:main Dec 12, 2022
@ramvikrams
Copy link
Contributor Author

thanks @ramvikrams

Thanks sir

@ramvikrams ramvikrams deleted the t2 branch January 23, 2023 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dr-Irv Dr-Irv Dr-Irv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing addition for TimedeltaSeries plus TimestampSeries
2 participants
@ramvikrams @Dr-Irv