allow a dict in DataFrame.astype() #449
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twoertwein
reviewed
Nov 27, 2022
pandas-stubs/core/frame.pyi
Outdated
| @@ -1357,7 +1357,7 @@ class DataFrame(NDFrame, OpsMixin): | |||
| ) -> DataFrame: ... | |||
| def astype( | |||
| self, | |||
| dtype: _str | Dtype | dict[_str, _str | Dtype] | Series, | |||
| dtype: _str | Dtype | Mapping[_str, _str | Dtype] | Series, | |||
There was a problem hiding this comment.
the keys can probably be any Hashable(T) as the columns might not be str.
There was a problem hiding this comment.
Could maybe add a test for a non-str column
There was a problem hiding this comment.
I modified the test to do a mix of column "names", i.e., a string and an int in fa76285
twoertwein
approved these changes
Nov 27, 2022
|
Thank you @Dr-Irv ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test_frame.py:test_astype_dict()