added pd.Index with tests in common.pyi #422
Conversation
|
Sir I had one doubt should the script test/nighly should be changed so that it's upgrades automatically for newer version of pip |
Just merged in #421 that fixes the nightly issue. So you can merge with latest master to fix that. |
tests/test_api_types.py
Outdated
| assert_type(api.is_array_like(pd.DataFrame({"a": [1, 2], "b": [3, 4]})), bool), | ||
| bool, | ||
| ) | ||
| check(assert_type(api.is_array_like(pd.Index([1, 2.0])), bool), bool) |
There was a problem hiding this comment.
can you change all of these to use a module-level variable. Right now, we have at the top of this file:
nparr = np.array([1, 2, 3])
arr = pd.Series([1, 2, 3])
obj = "True"
mapping = {"a": "a"}so you can add something for np.dtype(np.int32) , (pd.DataFrame({"a": [1, 2], "b": [3, 4]}) and pd.Index([1, 2.0]) up top, and reuse those variables throughout.
There was a problem hiding this comment.
sure sir i'll do it
There was a problem hiding this comment.
Done the changes sir
tests/test_api_types.py
Outdated
|
|
||
|
|
||
| def test_is_categorical_dtype() -> None: | ||
| check(assert_type(api.is_categorical_dtype(arr), bool), bool) | ||
| check(assert_type(api.is_categorical_dtype(nparr), bool), bool) | ||
| check(assert_type(api.is_categorical_dtype(dtylike), bool), bool) | ||
| check(assert_type(api.is_categorical_dtype(arr), bool), bool) |
There was a problem hiding this comment.
this is duplicate of a few lines above
Yes sir I'll fix it |
|
Done the change sir |
Thanks sir |
assert_type()to assert the type of any return value