Skip to content

MAINT: Fix for future change #409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Nov 8, 2022
Merged

MAINT: Fix for future change #409

merged 7 commits into from
Nov 8, 2022

Conversation

bashtage
Copy link
Contributor

@bashtage bashtage commented Nov 3, 2022

No description provided.

Dr-Irv
Dr-Irv requested changes Nov 3, 2022
View reviewed changes
Copy link
Collaborator

@Dr-Irv Dr-Irv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some ideas for improvement. Thanks for looking into this

@bashtage bashtage requested a review from Dr-Irv November 4, 2022 07:58
Dr-Irv
Dr-Irv requested changes Nov 4, 2022
View reviewed changes
Copy link
Collaborator

@Dr-Irv Dr-Irv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small typo in a comment, and would prefer to use pandas Version class

@bashtage bashtage requested a review from Dr-Irv November 4, 2022 18:55
Dr-Irv
Dr-Irv requested changes Nov 4, 2022
View reviewed changes
Copy link
Collaborator

@Dr-Irv Dr-Irv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we need to add a stub for pandas.util.version

Sorry to create more work. Hopefully stubgen can get you something useful.

bashtage and others added 2 commits November 5, 2022 23:48
@bashtage
ENH: Improve typing for Timedelta (pandas-dev#388)
b41391c 
* ENH: Improve typing for Timedelta

* ENH: Improve typing of timedelta

* ENH/TST: Improve Timedelta and its tests

* ENH: Final changes for timedelta

* ENH: Further improvements to timestamp

* ENH: Add more types

* Final changes to timedelta

* Final cleanup

* CLN: Final clean

* CLN: Final clean

Co-authored-by: Kevin Sheppard <[email protected]>
ENH: Add typing for Version
d77223a
@bashtage bashtage closed this Nov 6, 2022
@bashtage bashtage reopened this Nov 6, 2022
@Dr-Irv
Copy link
Collaborator

Dr-Irv commented Nov 8, 2022

@bashtage Not sure how you want to handle this. Looks like latest pandas nightly has an issue with matplotlib.

@bashtage
Copy link
Contributor Author

bashtage commented Nov 8, 2022

@bashtage Not sure how you want to handle this. Looks like latest pandas nightly has an issue with matplotlib.

I think this one is ready and it still fixes the one issue. The MPL seems like it will be fixed upstream.

@Dr-Irv
Copy link
Collaborator

Dr-Irv commented Nov 8, 2022

@bashtage Not sure how you want to handle this. Looks like latest pandas nightly has an issue with matplotlib.

I think this one is ready and it still fixes the one issue. The MPL seems like it will be fixed upstream.

Issue here is that the pytest is failing, and the typing check on nightly never happens, so maybe change the order of the tests on nightly to do the typing tests first, and then do pytest tests?

@bashtage
Copy link
Contributor Author

bashtage commented Nov 8, 2022

It doesn't run typing against nightly at all -- I think this makes sense since typing is internal to pandas-stubs. It only runs pytest to try and find issues where pytest will fail.

@Dr-Irv
Copy link
Collaborator

Dr-Irv commented Nov 8, 2022

It doesn't run typing against nightly at all -- I think this makes sense since typing is internal to pandas-stubs. It only runs pytest to try and find issues where pytest will fail.

OK. I remembered the failure we had with Version, but that was in the regular checks.

Dr-Irv
Dr-Irv approved these changes Nov 8, 2022
View reviewed changes
Copy link
Collaborator

@Dr-Irv Dr-Irv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @bashtage

@Dr-Irv Dr-Irv merged commit 90c1b61 into pandas-dev:main Nov 8, 2022
@bashtage bashtage deleted the future-fix branch November 8, 2022 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dr-Irv Dr-Irv Dr-Irv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bashtage @Dr-Irv