Fix value_counts and apply. #401
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's possible for the callable in Series.apply to return something non-hashable like a list, but the result of apply should still be a Series.
Whether it returns a Series or a DataFrame depends on the return type of the callable. In the case of the callable returning a scalar, the result is a Series unless the result_type is "broadcast".
danielroseman
force-pushed
the
more-apply-fixes
branch
from
acbd4a9 to
e8d6a77
Compare
gandhis1
reviewed
Oct 26, 2022
| @@ -685,7 +685,7 @@ class Series(IndexOpsMixin, NDFrame, Generic[S1]): | |||
| @overload | |||
| def apply( | |||
| self, | |||
| func: Callable[..., Hashable], | |||
| func: Callable[..., Scalar | Sequence | Mapping], | |||
There was a problem hiding this comment.
Don't we basically assume everywhere in this code base that the expectation is that dataframes and series only store hashable/scalar types, and NOT things like dicts, or arbitrary objects for the matter?
There was a problem hiding this comment.
Yes, but in this case, it doesn't matter, because he is defining a Callable that returns types, that apply will then use to return a Series.
|
@Dr-Irv test added as requested. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a few issues.
Series.value_countswas wrongly typed as returning a series of the same type as the original (Series[S1]), when it actually returnsSeries[int].Series.applydoes not need to be hashable; it can return any value valid for a Series, which can include non-hashable items like lists or dicts.DataFrame.apply, likeDataFrameGroupBy.apply, returns a DataFrame or Series depending on the return value of the callable, not on the set of parameters given. The exception is whenresult_typeis "broadcast", in which case the result is always a DataFrame.assert_type()to assert the type of any return value