ENH: Improve typing for Timestamp #389
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bashtage
force-pushed
the
scalars-timestamp
branch
from
ef4f457 to
311a199
Compare
bashtage
force-pushed
the
scalars-timestamp
branch
from
f4888eb to
1666a67
Compare
|
@Dr-Irv I think this is also ready - it follows the style of the other two PRs. |
Dr-Irv
requested changes
Nov 2, 2022
|
#408 should go in first, but it is already in this one. |
|
@Dr-Irv Resolved everything - most with fixes, one with a comment. |
Dr-Irv
requested changes
Nov 3, 2022
Dr-Irv
approved these changes
Nov 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
assert_type()to assert the type of any return valuexref ENH: Improve Pandas scalars #383