Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ENH: Improve Pandas scalars #383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Improve Pandas scalars #383
Changes from 10 commits
5c0dc1c
9f5058f
7ad615a
fb6d782
fecd9f9
5adba7b
c4dca27
d86adfd
79f56c2
cc390f5
c044a8c
f58c47c
fbfa4c1
ccbde88
25aa8c9
290f951
e62cc10
9c6b963
e93ca54
9070b0d
28e127e
f59c689
2f262d4
7dd8c56
9c2d500
0c2f5ca
e224537
08156cc
1672751
4c3ea13
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the error might be due to having conflicts between one of the
__add__()
declarations allowingPeriod
. So try__radd__()
with each one of the types in_PeriodAddSub
to narrow down the possible cause.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is because Period + Index -> PeriodIndex here but Index + Period -> Index there.