Y026: explicitly declare type aliases as TypeAlias #349
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twoertwein
commented
Sep 30, 2022
| @@ -4,4 +4,4 @@ version_json: str = ... | |||
|
|
|||
| def get_versions(): ... | |||
|
|
|||
| _stub_version = Literal["1.5.0.220926"] | |||
| _stub_version: Literal["1.5.0.220926"] | |||
There was a problem hiding this comment.
Not sure why this is needed.
If we assign Literal as a value, we need a TypeAlias, but the type alias is unused (private type aliases need to be used) which triggers another check from flake8-pyi.
There was a problem hiding this comment.
Microsoft is copying the stubs over to the VS Code pylance distribution, so by having this, we can tell what version they copied over.
|
Would be nice to slowly move all the TypeAliases that are not in _typing to something like __typing (no need to make things worse for #128) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #345
(and remove
FilePathOrBuffer- it does not exist anymore in pandas)