Skip to content

Remove use of removed mypy option #337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 28, 2022
Merged

Conversation

hauntsaninja
Copy link
Contributor

I removed this in 0.981

This got removed in 0.981
@Dr-Irv
Copy link
Collaborator

Dr-Irv commented Sep 27, 2022

So even without this change, we are now failing with mypy 0.981. Tracking in #336

@twoertwein
Copy link
Member

So even without this change, we are now failing with mypy 0.981. Tracking in #336

I think it will take some time to be compatible with 0.981.

@hauntsaninja For now, it would be good to limit the mypy version in pyproject.toml. Making any change to pyproject.toml invalidates the cached poetry.lock file which in this case installs the new mypy and lets everything fail.

@Dr-Irv
Copy link
Collaborator

Dr-Irv commented Sep 27, 2022

@hauntsaninja For now, it would be good to limit the mypy version in pyproject.toml. Making any change to pyproject.toml invalidates the cached poetry.lock file which in this case installs the new mypy and lets everything fail.

Good idea

Copy link
Collaborator

@Dr-Irv Dr-Irv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @hauntsaninja

@Dr-Irv Dr-Irv merged commit 46ee67b into pandas-dev:main Sep 28, 2022
@hauntsaninja hauntsaninja deleted the patch-1 branch September 28, 2022 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants