Skip to content

MAINT: Exclude OSX-3.10.6 #335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 28, 2022
Merged

Conversation

bashtage
Copy link
Contributor

Stop running for now

@Dr-Irv
Copy link
Collaborator

Dr-Irv commented Sep 27, 2022

I don't understand the need for this PR. I'm seeing successful workflows with all 3 MacOS tests.

@bashtage
Copy link
Contributor Author

You don't see them because I usually rerun the failed tests when OSX 3.10 times out. Here is one where I didn't rerun

https://github.com/pandas-dev/pandas-stubs/actions/runs/3129422399

@Dr-Irv
Copy link
Collaborator

Dr-Irv commented Sep 27, 2022

You don't see them because I usually rerun the failed tests when OSX 3.10 times out. Here is one where I didn't rerun

https://github.com/pandas-dev/pandas-stubs/actions/runs/3129422399

I've seen these "operations were cancelled" on Windows and MacOS, with different versions of python. It's something funky on the github end, since it is so inconsistent. What I usually do is just go in and rerun the failed job, and it goes through.

@Dr-Irv Dr-Irv closed this Sep 27, 2022
@bashtage
Copy link
Contributor Author

It has happened literally every other run on OSX 3.10 I don't think it adds much to have all 3 by 3 and it is a real pain.

@Dr-Irv
Copy link
Collaborator

Dr-Irv commented Sep 27, 2022

I just did a rerun of a failure, and it failed a LOT because mypy upgraded to 0.981 yesterday (9/26)

@Dr-Irv
Copy link
Collaborator

Dr-Irv commented Sep 27, 2022

So we might start seeing lots of failures everywhere. Will try to look at this later today

@bashtage
Copy link
Contributor Author

I'm going to reopen this as an appeal. My other PR has not had 3 times outs on OSX 3.10. Something is just not right on OSX and 3.10.

@bashtage bashtage reopened this Sep 28, 2022
@Dr-Irv
Copy link
Collaborator

Dr-Irv commented Sep 28, 2022

The fix is to edit .github/workflows/test.yml and increase the time limit from 10 minutes to 20 minutes here:

timeout-minutes: 10

Copy link
Collaborator

@Dr-Irv Dr-Irv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @bashtage

I was also seeing timeouts on some Windows runs, so I think this will help alleviate this issue

@Dr-Irv Dr-Irv merged commit 55aa80f into pandas-dev:main Sep 28, 2022
@bashtage bashtage deleted the disable-osx-3.10 branch September 28, 2022 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants