Skip to content

ENH: Add use_na_sentinal #333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 27, 2022
Merged

ENH: Add use_na_sentinal #333

merged 3 commits into from
Sep 27, 2022

Conversation

bashtage
Copy link
Contributor

@bashtage
Copy link
Contributor Author

This OSX 3.10 issue is gettign annoying.

Dr-Irv
Dr-Irv requested changes Sep 27, 2022
View reviewed changes
pandas-stubs/core/arrays/sparse/array.pyi Outdated
# Not actually positional-only, used to handle deprecations in 1.5.0
*,
use_na_sentinel: bool = ...,
): ...
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can use tuple[nd.ndarray, SparseArray] here and do a # type: ignore to get around mypy complaint.

Dr-Irv
Dr-Irv approved these changes Sep 27, 2022
View reviewed changes
Copy link
Collaborator

@Dr-Irv Dr-Irv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bashtage

@Dr-Irv Dr-Irv merged commit cbe73a6 into pandas-dev:main Sep 27, 2022
@bashtage bashtage deleted the use_na_sentinal branch September 28, 2022 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dr-Irv Dr-Irv Dr-Irv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bashtage @Dr-Irv