Skip to content

ENH: Add from_dummies #330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 27, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions pandas-stubs/__init__.pyi
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,7 @@ from .core.reshape.api import (
concat as concat,
crosstab as crosstab,
cut as cut,
from_dummies as from_dummies,
get_dummies as get_dummies,
lreshape as lreshape,
melt as melt,
Expand Down
5 changes: 4 additions & 1 deletion pandas-stubs/core/reshape/api.pyi
Original file line number Diff line number Diff line change
@@ -1,4 +1,8 @@
from pandas.core.reshape.concat import concat as concat
from pandas.core.reshape.encoding import (
from_dummies as from_dummies,
get_dummies as get_dummies,
)
from pandas.core.reshape.melt import (
lreshape as lreshape,
melt as melt,
Expand All @@ -14,7 +18,6 @@ from pandas.core.reshape.pivot import (
pivot as pivot,
pivot_table as pivot_table,
)
from pandas.core.reshape.reshape import get_dummies as get_dummies
from pandas.core.reshape.tile import (
cut as cut,
qcut as qcut,
Expand Down
31 changes: 31 additions & 0 deletions pandas-stubs/core/reshape/encoding.pyi
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
from typing import (
Hashable,
Iterable,
)

from pandas import (
DataFrame,
Series,
)

from pandas._typing import (
ArrayLike,
Dtype,
HashableT,
)

def get_dummies(
data: ArrayLike | DataFrame | Series,
prefix: str | Iterable[str] | dict[HashableT, str] | None = ...,
prefix_sep: str = ...,
dummy_na: bool = ...,
columns: list[HashableT] | None = ...,
sparse: bool = ...,
drop_first: bool = ...,
dtype: Dtype | None = ...,
) -> DataFrame: ...
def from_dummies(
data: DataFrame,
sep: str | None = ...,
default_category: Hashable | dict[str, Hashable] | None = ...,
) -> DataFrame: ...
16 changes: 0 additions & 16 deletions pandas-stubs/core/reshape/reshape.pyi

This file was deleted.

66 changes: 66 additions & 0 deletions tests/test_utility.py
Original file line number Diff line number Diff line change
Expand Up @@ -9,3 +9,69 @@ def test_show_version():
with pytest.warns(UserWarning, match="Setuptools is replacing distutils"):
check(assert_type(pd.show_versions(True), None), type(None))
check(assert_type(pd.show_versions(False), None), type(None))


def test_dummies():
df = pd.DataFrame(
pd.Series(["a", "b", "a", "b", "c", "a", "a"], dtype="category"), columns=["A"]
)
dummies = pd.get_dummies(df)
check(assert_type(dummies, pd.DataFrame), pd.DataFrame)
check(assert_type(pd.from_dummies(dummies), pd.DataFrame), pd.DataFrame)

df2 = pd.DataFrame(
pd.Series(["a", "b", "a", "b", "c", "a", "a"], dtype="category"),
columns=[("A",)],
)
check(
assert_type(pd.get_dummies(df2, prefix={("A",): "bar"}), pd.DataFrame),
pd.DataFrame,
)


def test_get_dummies_args():
df = pd.DataFrame(
{
"A": pd.Series(["a", "b", "a", "b", "c", "a", "a"], dtype="category"),
"B": pd.Series([1, 2, 1, 2, 3, 1, 1]),
}
)
check(
assert_type(
pd.get_dummies(df, prefix="foo", prefix_sep="-", sparse=True), pd.DataFrame
),
pd.DataFrame,
)
check(
assert_type(
pd.get_dummies(
df, prefix=["foo"], dummy_na=True, drop_first=True, dtype="bool"
),
pd.DataFrame,
),
pd.DataFrame,
)
check(
assert_type(
pd.get_dummies(df, prefix={"A": "foo", "B": "baz"}, columns=["A", "B"]),
pd.DataFrame,
),
pd.DataFrame,
)


def test_from_dummies_args():
df = pd.DataFrame(
{
"A": pd.Series(["a", "b", "a", "b", "c", "a", "a"], dtype="category"),
}
)
dummies = pd.get_dummies(df, drop_first=True)

check(
assert_type(
pd.from_dummies(dummies, sep="_", default_category="a"),
pd.DataFrame,
),
pd.DataFrame,
)