MAINT: Bump pandas to 1.5.0 #317
Conversation
|
1.5.0 Released this weekend. |
|
I think we can take the whatsnew document and create a list of all the deprecations. Can you do that in #227 with a checklist so it makes it easier to see which ones you have done and which ones are still to be done? this will make it easier for me to review. Thanks!!! |
|
@bashtage Not sure you saw my comment here: #317 (comment) It would be easier to review if we have a tracking list of all the 1.5 changes we need to make. Can you make such a list? |
That would definitly be the easier for reviewers :) (but going through the changelog is no fun). Later today, I will simply execute code with the removed arguments to test whether they raise warnings. It might not cover all deprecations, but I can then at least approve this PR. |
bashtage
force-pushed
the
move-to-1.5.0
branch
from
f1ba252 to
48cdc77
Compare
|
I created a list for all of the 1.5 issues (changes and deprecations) here: #227 (comment) So as they get fixed, we can edit that comment and check off the boxes and put a link to the relevant PR I'll use that list to cross-check against this PR once it turns green again. @bashtage ping me when green |
There was a problem hiding this comment.
Other simple ones to do with deprecations for this PR (there are more to do in a later PR):
- remove
__array_wrap__()fromcore/generic.pyi - Deprecated Timedelta.freq and Timedelta.is_populated
- Deprecated Timedelta.delta
Am tracking in #227 what you did here, and would need to update that if you do the above 3.
Other concern (which is marked in a few places in this review) is the deletion of tests that addressed previously reported issues with respect to groupby.__iter__(). Please don't delete old tests (unless they are no longer relevant)
Thanks for all the work on this.
| @@ -278,7 +278,7 @@ class Styler(StylerRenderer[Styler]): | |||
| ) -> Styler: ... | |||
| def highlight_null( | |||
| self, | |||
| null_color: str = ..., | |||
| color: str | None = ..., | |||
There was a problem hiding this comment.
docs are missing None as an argument - can you create an issue for that?
There was a problem hiding this comment.
Docs on that one are pretty wrong. Have wrong color too
There was a problem hiding this comment.
- We're in disagreement about the deprecation of
groupby(Scalar). The code that was in the test suite still works without a deprecation message, so can you put back all of those changes, or prove to me otherwise. - With respect to
factorize(), you can still include it. The error you were getting was becausemypydoesn't allow a subclass to return a subtype of the parent's class return type.pyrightallows that. So just put a# type: ignoreincore/arrays/sparse.pyiforfactorizeand then you should be good (with docs about why it is necessary). - For
ExcelWriter, some methods/properties were deprecated, but there is a list of them that are now public, and you removed them. Maybe you misunderstood the list I created, so those need to be in there (e.g.,book,sheets, etc.)
|
Think it is ready. |
No description provided.