Fix replace, fillna allowing pd.NA. Allow list of arguments for .loc #312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

twoertwein merged 2 commits into pandas-dev:main from Dr-Irv:misc0917

Sep 18, 2022

Collaborator

Dr-Irv commented Sep 17, 2022

Closes Error shown when assigning value to df.loc[List[StrLike]] #254
Closes error: No overload variant of "replace" of "DataFrame" matches argument types "str", "NAType" [call-overload] #262
Closes error: No overload variant of "fillna" of "Series" matches argument type "NAType" [call-overload] #263
Tests added:
- test_frame.py
  - test_setitem_loc()
  - test_replace_na()
- test_series.py: New test in test_types_fillna()

Dr-Irv added 2 commits

September 17, 2022 16:05


          Fix replace, fillna allowing pd.NA. Allow list of arguments for .loc

e47a276


          add check and assert_type

bae2c58

Dr-Irv requested a review from twoertwein

September 18, 2022 04:29

twoertwein approved these changes

View reviewed changes

twoertwein merged commit 7c38e4d into pandas-dev:main

Member

twoertwein commented Sep 18, 2022

Thanks @Dr-Irv

Dr-Irv deleted the misc0917 branch

December 28, 2022 15:19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet