Skip to content

ENH: Improve Roling, Expanding and EWM #297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Sep 19, 2022

Conversation

bashtage
Copy link
Contributor

  • Closes #xxxx (Replace xxxx with the Github issue number)
  • Tests added: Please use assert_type() to assert the type of any return value

@bashtage bashtage marked this pull request as draft September 13, 2022 16:34
@bashtage
Copy link
Contributor Author

All three of these need to be made generic NDFrameT.

@Dr-Irv
Copy link
Collaborator

Dr-Irv commented Sep 13, 2022

Merge to main as that will make the CI get past the 3.10.7 issue.

@bashtage bashtage force-pushed the moving-rolling-expanding branch from 3d67900 to da3e116 Compare September 14, 2022 05:46
@Dr-Irv
Copy link
Collaborator

Dr-Irv commented Sep 14, 2022

assign me as a reviewer when it's all green and not in draft status.

@bashtage bashtage marked this pull request as ready for review September 15, 2022 09:04
@bashtage bashtage requested a review from Dr-Irv September 16, 2022 17:06
Copy link
Collaborator

@Dr-Irv Dr-Irv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really good. Like the tests. Just a few things to clean up

@bashtage
Copy link
Contributor Author

Think I got them all, green now.

Copy link
Collaborator

@Dr-Irv Dr-Irv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @bashtage

@Dr-Irv Dr-Irv merged commit 315683f into pandas-dev:main Sep 19, 2022
@bashtage bashtage mentioned this pull request Sep 24, 2022
@bashtage bashtage deleted the moving-rolling-expanding branch September 27, 2022 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants