Skip to content

ENH: Improve Styler typing #282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Sep 12, 2022
Merged

ENH: Improve Styler typing #282

merged 14 commits into from
Sep 12, 2022

Conversation

bashtage
Copy link
Contributor

@bashtage bashtage commented Sep 8, 2022

  • Tests added: Please use assert_type() to assert the type of any return value

Copy link
Collaborator

@Dr-Irv Dr-Irv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caught a lot of stuff by just comparing the docs to what is in here. Didn't check if we are missing any Styler methods that are documented.

Copy link
Collaborator

@Dr-Irv Dr-Irv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few more things I caught, and some things from previous comments that weren't addressed (mostly related to Axis)

@Dr-Irv
Copy link
Collaborator

Dr-Irv commented Sep 9, 2022

Just realized where I wrote Axis, I meant AxisType !!

@bashtage
Copy link
Contributor Author

I think this is ready unless I missed something.

Copy link
Collaborator

@Dr-Irv Dr-Irv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @bashtage

@Dr-Irv Dr-Irv merged commit ad517c7 into pandas-dev:main Sep 12, 2022
@bashtage bashtage deleted the styler branch September 15, 2022 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants