Skip to content

MAINT: Show python info on Windows #246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 1, 2022
Merged

Conversation

bashtage
Copy link
Contributor

@bashtage bashtage commented Sep 1, 2022

  • Closes #xxxx (Replace xxxx with the Github issue number)
  • Tests added: Please use assert_type() to assert the type of any return value

@bashtage
Copy link
Contributor Author

bashtage commented Sep 1, 2022

@Dr-Irv @twoertwein I think it would be good to get this in - it might help diagnose cache issues since we could see if the location of the virtualenv was changing, and it somehow windows was missing the location of the venv python.exe.

Copy link
Collaborator

@Dr-Irv Dr-Irv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bashtage

@Dr-Irv
Copy link
Collaborator

Dr-Irv commented Sep 1, 2022

Might be worth trying this without the pinning of the poetry version. I think it worked because it picked up an "old" cache.

@Dr-Irv Dr-Irv merged commit 15447ae into pandas-dev:main Sep 1, 2022
@twoertwein
Copy link
Member

Might also be good to make the cache key dependent on poetry run python --version instead of using the string from the matrix setup.

@bashtage bashtage deleted the experiments branch September 3, 2022 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants