Skip to content

Add AnyArrayLike for merge on arguments #231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 28, 2022
Merged

Conversation

phofl
Copy link
Member

@phofl phofl commented Aug 26, 2022

  • Closes #xxxx (Replace xxxx with the Github issue number)
  • Tests added: Please use assert_type() to assert the type of any return value

These are all valid inputs for the on arguments

Copy link
Collaborator

@Dr-Irv Dr-Irv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With any new tests, we're asking people to use check and assert_type. So can you change these to be (for example):

check(assert_type(df.merge(df2, on=pd.Series([1, 2, 3])), pd.DataFrame, pd.DataFrame)

@phofl
Copy link
Member Author

phofl commented Aug 27, 2022

Added, wasn't aware that we should also add for argument checks

Copy link
Collaborator

@Dr-Irv Dr-Irv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @phofl

@Dr-Irv Dr-Irv merged commit 713008d into pandas-dev:main Aug 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants