-
-
Notifications
You must be signed in to change notification settings - Fork 141
CI: run stubtest #178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
CI: run stubtest #178
Changes from 4 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
b47fff0
CI: run stubtest
twoertwein cf7d257
maybe fix windows bug?
twoertwein 2a32d60
remove allowlist
twoertwein 6f61678
isort
twoertwein f2dfc42
remove non-existing files
twoertwein c3ef418
slightly nicer solution?
twoertwein c9451f5
fix most default arguments
twoertwein f7ed979
remove very few of the many non-existing things
twoertwein 5567a39
read_json
twoertwein File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,5 @@ | ||
from copy import copy | ||
from functools import partial | ||
from typing import Literal | ||
|
||
from scripts._job import run_job | ||
|
@@ -10,8 +12,6 @@ | |
_step.rename_src, | ||
_step.mypy_dist, | ||
_step.pyright_dist, | ||
_step.uninstall_dist, | ||
_step.restore_src, | ||
] | ||
|
||
|
||
|
@@ -33,3 +33,9 @@ def test( | |
steps = [step for step in steps if remove not in step.name] | ||
|
||
run_job(steps) | ||
|
||
|
||
def stubtest(allowlist: str): | ||
stubtest = copy(_step.stubtest) | ||
stubtest.run = partial(_step.stubtest.run, allowlist=allowlist) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. a bit ugly but I didn't see another way with the current test structure. |
||
run_job(_DIST_STEPS[:-2] + [stubtest]) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unrelated: run the rollbacks when none of the steps failed (instead of having to specify the rollback as a step)