Add Tuple[slice] in iLocIndexerFrame. Fix #143

[AchmadFathoni]

• Closes [BUG] Argument of type "tuple[slice]" cannot be assigned to parameter "idx"  #143
• Tests added: Please use assert_type() to assert the type of any return value

[bashtage]

Is that an actual supported mode for iloc? Or just an accident that works because tuples are unpacked in __s/getitem__?

https://pandas.pydata.org/docs/reference/api/pandas.DataFrame.iloc.html

[AchmadFathoni]

I don't know, I'm out of deep in this topic. I just following @Dr-Irv suggestion.

[Dr-Irv]

Is that an actual supported mode for iloc? Or just an accident that works because tuples are unpacked in __s/getitem__?

https://pandas.pydata.org/docs/reference/api/pandas.DataFrame.iloc.html

The example in the issue is df.iloc[0:2,]. Here the arguments to __getitem__() is tuple(slice,). Agreed it's an odd usage, but valid.

[Dr-Irv]

Can you also add a test in test_frame.py that fails without this change, and works with it? Copying the code from the original issue will suffice. Make sure to include a comment that refers to the issue.

[bashtage]

The example in the issue is df.iloc[0:2,]. Here the arguments to __getitem__() is tuple(slice,). Agreed it's an odd usage, but valid.

I agree it works. I am just querying if pandas-stubs should be adding types that aren't part of the docstring. Shouldn't there be a change upstream to confirm that this is a supported format?

[Dr-Irv]

CI failing due to black. Do poe style to make sure everything is OK.

[Dr-Irv]

Sorry - I should have picked up on this before. Use

tuple[IndexType | MaskType, IndexType | MaskType | slice]

[AchmadFathoni]

That change fails the test I made

Type "tuple[slice]" cannot be assigned to type "IndexType | MaskType | tuple[IndexType | MaskType, IndexType | MaskType]"

[Dr-Irv]

My mistake. I missed the comma

[Dr-Irv]

Thanks @AchmadFathoni