Allow subtypes of List[Scalar] by introducing ScalarArg #124
Conversation
pandas-stubs/_typing.pyi
Outdated
| @@ -122,6 +122,7 @@ Scalar = Union[ | |||
| Timestamp, | |||
| Timedelta, | |||
| ] | |||
| ScalarArg = TypeVar("ScalarArg", bound=Scalar) | |||
There was a problem hiding this comment.
Maybe ScalarT to emphasize that it is a TypeVar.
Even though _typing.py is private, it might be good to make all variables that are not actually in pandas explicitly private. Users might want to import some of the type variables from pandas to annotate their own code.
There was a problem hiding this comment.
Maybe
ScalarTto emphasize that it is aTypeVar.
Good idea. Done in next commit.
Even though
_typing.pyis private, it might be good to make all variables that are not actually in pandas explicitly private. Users might want to import some of the type variables from pandas to annotate their own code.
That could be something we do in the future. One thing I would like to do is reconcile the things in pandas._typing.py and pandas-stubs._typing.pyi, because there are some inconsistencies. Created #128
|
@twoertwein once this is approved and merged, I'm going to do a new release. |
|
Thank you @Dr-Irv ! |
test_frame.py:test_columns_mixlist()