GH1173 Experiment with fuller typing #1193
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
You'd still need to have the |
Dr-Irv
reviewed
Apr 21, 2025
Comment on lines
+679
to
+685
| parser: Literal["pandas", "python"] = ..., | ||
| engine: Literal["python", "numexpr"] | None = ..., | ||
| local_dict: dict[_str, Any] | None = ..., | ||
| global_dict: dict[_str, Any] | None = ..., | ||
| resolvers: list[Mapping] | None = ..., | ||
| level: int = ..., | ||
| target: object | None = ..., |
There was a problem hiding this comment.
Can you indicate where you found this list of possible keyword arguments?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kwargsinDataFrame.queryaccording toDataFrame.eval#1173assert_type()to assert the type of any return value@MarcoGorelli I took a try at your idea of typehinting the whole set of arguments in
pd.DataFrame.querybut stumbling upon the issue when the user passes a dictionary (which is still an allowed behavior).Wondering if there is something I am missing here, please let me know!