GH1184 Clean up new warnings with new version of pyright (1.1.399) #1185
Conversation
| @@ -219,6 +219,7 @@ reportUnknownParameterType = false | |||
| reportUnknownVariableType = false | |||
| reportUnusedVariable = false | |||
| reportPrivateUsage = false | |||
| reportPrivateImportUsage = false | |||
There was a problem hiding this comment.
So this becomes a problem, because reportPrivateImportUsage = true is on when people use pyright and pandas-stubs is installed.
See microsoft/pyright#10248 for a discussion. It looks like the pyright maintainer is going to consider reverting the change that created this issue, so if he does that, we can handle this PR later.
There was a problem hiding this comment.
Okay that is very insightful!
Let's hold on this PR before pyright clarifies the situation, for now the other PRs I have made have locked pyright version.
There was a problem hiding this comment.
@loicdiridollou pyright 1.1.400 has been released and they removed the thing that tests for private imports. Can you update pyproject.toml in this PR so that we can get the CI to pass with 1.1.400?
|
Thanks for tracking the progress, indeed I saw it was reverted while pandas
work on the issue on their end.
Let me clean this up with pyright >=1.1.400 and make sure it all
runs smoothly. Will be done by end of day.
…On Thu, Apr 24, 2025 at 9:59 AM Irv Lustig ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In pyproject.toml
<#1185 (comment)>
:
> @@ -219,6 +219,7 @@ reportUnknownParameterType = false
reportUnknownVariableType = false
reportUnusedVariable = false
reportPrivateUsage = false
+reportPrivateImportUsage = false
@loicdiridollou <https://github.com/loicdiridollou> pyright 1.1.400 has
been released and they removed the thing that tests for private imports.
Can you update pyproject.toml in this PR so that we can get the CI to
pass with 1.1.400?
—
Reply to this email directly, view it on GitHub
<#1185 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AMQNSQGLPNEXUC7I57QWCJ323DU4ZAVCNFSM6AAAAAB3AFW4B2VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDOOJRGMZDKNJVGQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
assert_type()to assert the type of any return value