type dataframe.transpose #1136
Merged
type dataframe.transpose #1136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcoGorelli
commented
Mar 2, 2025
pandas-stubs/core/series.pyi
Outdated
Comment on lines
1601
to
1542
| def transpose(self, *args, **kwargs) -> Series[S1]: ... | ||
| def transpose(self, axes: None = ...) -> Series[S1]: ... |
There was a problem hiding this comment.
The only argument that pandas actually lets us pass at runtime is axes=None
For Series and Index, it can be passed positionally or by name
For DataFrame, it can only be passed positionally
MarcoGorelli
commented
Mar 2, 2025
Comment on lines
56
to
59
| def transpose(self, *axes): ... | ||
| def transpose(self, *axes: Any) -> Self: ... |
There was a problem hiding this comment.
axes is totally ignored in SparseArray.transpose
MarcoGorelli
force-pushed
the
type-transpose
branch
from
1cd95d1 to
f752851
Compare
MarcoGorelli
force-pushed
the
type-transpose
branch
from
f752851 to
6189b5c
Compare
Dr-Irv
requested changes
Mar 3, 2025
| @@ -53,7 +56,7 @@ class SparseArray(ExtensionArray, ExtensionOpsMixin): | |||
| def sum(self, axis: int = ..., *args, **kwargs): ... | |||
| def cumsum(self, axis: int = ..., *args, **kwargs): ... | |||
| def mean(self, axis: int = ..., *args, **kwargs): ... | |||
| def transpose(self, *axes): ... | |||
| def transpose(self, *axes: Any) -> Self: ... | |||
There was a problem hiding this comment.
We should delete this. SparseArray.transpose() is not documented. In fact, only the constructor is documented, so we should delete all the methods for SparseArray except __init__(). Can you do that here?
MarcoGorelli
commented
Mar 4, 2025
Dr-Irv
requested changes
Mar 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
assert_type()to assert the type of any return value