type dataframe.replace #1129
Merged
type dataframe.replace #1129
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcoGorelli
commented
Feb 21, 2025
Dr-Irv
requested changes
Feb 21, 2025
pandas-stubs/core/frame.pyi
Outdated
| ) = ..., | ||
| value: ( | ||
| Scalar | NAType | Sequence[Scalar] | Mapping[Hashable, Scalar] | None | ||
| ) = ..., | ||
| *, | ||
| inplace: Literal[True], | ||
| limit: int | None = ..., |
There was a problem hiding this comment.
limit is deprecated, so we should remove it.
pandas-stubs/core/frame.pyi
Outdated
| | Pattern | ||
| | Sequence[str | Pattern] | ||
| | Mapping[Hashable, str | Pattern] | ||
| ) = ..., | ||
| method: ReplaceMethod = ..., |
There was a problem hiding this comment.
method is deprecated so we should remove it
Dr-Irv
approved these changes
Feb 24, 2025
There was a problem hiding this comment.
@MarcoGorelli this looks good to me. I'll merge it in when you change it from draft status. Ping me when that is done.
|
Thanks @Dr-Irv ! It was doing my head in trying to cover all the possibilities in all arguments so I made an alias |
Yes. Let me know when it's ready for review |
|
Ready for review, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
assert_type()to assert the type of any return value