type tz in tz_convert, tz_localize, date_range, and bdate_range
#1118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcoGorelli
commented
Feb 13, 2025
| @@ -820,4 +821,6 @@ TimeGrouperOrigin: TypeAlias = ( | |||
| ExcelReadEngine: TypeAlias = Literal["xlrd", "openpyxl", "odf", "pyxlsb", "calamine"] | |||
| ExcelWriteEngine: TypeAlias = Literal["openpyxl", "odf", "xlsxwriter"] | |||
|
|
|||
| TimeZones: TypeAlias = str | tzinfo | None | int | |||
There was a problem hiding this comment.
the related (private, for some reason?) alias in pandas is _TimeZones:
I think TimeZone would be more accurate? I don't really mind, just explaining why I used the plural and where it comes from
Dr-Irv
approved these changes
Feb 13, 2025
There was a problem hiding this comment.
Thanks @MarcoGorelli . Nice find that we were missing the types in multiple places.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
assert_type()to assert the type of any return value