Skip to content

Simplify DataFrame.loc.__getitem__ overload #574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
randolf-scholz opened this issue Mar 14, 2023 · 1 comment
Closed

Simplify DataFrame.loc.__getitem__ overload #574

randolf-scholz opened this issue Mar 14, 2023 · 1 comment

Comments

@randolf-scholz
Copy link
Contributor

Describe the bug

We can simplify

pandas-stubs/pandas-stubs/core/frame.pyi

Lines 162 to 166 in d2e3f74

| tuple[
IndexType | MaskType | list[HashableT] | Hashable,
list[HashableT] | slice | Series[bool] | Callable,
],
) -> DataFrame: ...

towards

        | tuple[
            Iterable[Hashable] | slice | Hashable,
            list[HashableT] | slice | Series[bool] | Callable,
        ],
    ) -> DataFrame: ...

Please complete the following information:

  • pandas 1.5.3
  • pandas-stubs 1.5.3.230304
randolf-scholz added a commit to randolf-scholz/pandas-stubs that referenced this issue Mar 14, 2023
@randolf-scholz
abandoned pandas-dev#573, but reworked as pandas-dev#574
73fc26c
@randolf-scholz randolf-scholz mentioned this issue Mar 14, 2023
Closed
2 tasks
@Dr-Irv
Copy link
Collaborator

Dr-Irv commented Mar 14, 2023

As discussed here: #575 (comment) , Iterable[Hashable] is too wide

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Dataframe loc randolf-scholz/pandas-stubs
2 participants
@Dr-Irv @randolf-scholz