You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
If possible - and this may not be possible today - ensure that args and kwargs parameters are type checked against the passed-in Callable
Comprehensive set of tests are needed here, to exercise all variations
I'll start with transform because that is a fairly simple API compared to the others and it is not very commonly used, so the potential impact of more narrow types there has a lower risk of an impactful regression.
The text was updated successfully, but these errors were encountered:
All of these groupby operations take a function that can be a
str
or aCallable
. They should ensure that:Callable
accepts a first parameter that is aDataFrame
orSeries
as applicableCallable
returns the appropriate type - in some cases anIterable
, in other cases either aDataFrame
orSeries
str
is passed in, it is part of the set of supported functions, which are located here: https://github.com/pandas-dev/pandas/blob/main/pandas/core/groupby/base.py#L60args
andkwargs
parameters are type checked against the passed-inCallable
I'll start with
transform
because that is a fairly simple API compared to the others and it is not very commonly used, so the potential impact of more narrow types there has a lower risk of an impactful regression.The text was updated successfully, but these errors were encountered: