GH1139 PR Feedback

Author: loicdiridollou

pandas-stubs/core/series.pyi

@@ -1043,18 +1043,7 @@ class Series(IndexOpsMixin[S1], NDFrame):
     @overload
     def rename(
         self,
-        index: None = ...,
-        *,
-        axis: Axis | None = ...,
-        copy: bool = ...,
-        inplace: Literal[True],
-        level: Level | None = ...,
-        errors: IgnoreRaise = ...,
-    ) -> None: ...
-    @overload
-    def rename(
-        self,
-        index: Hashable,
+        index: Hashable | None,
         *,
         axis: Axis | None = ...,
         copy: bool = ...,
@@ -1065,7 +1054,7 @@ class Series(IndexOpsMixin[S1], NDFrame):
     @overload
     def rename(
         self,
-        index: Renamer | None = ...,
+        index: Renamer = ...,
         *,
         axis: Axis | None = ...,
         copy: bool = ...,

tests/test_series.py

@@ -1238,8 +1238,11 @@ def add1(x: int) -> int:
         type(None),
     )
     check(
-        assert_type(pd.Series([1, 2, 3]).rename(index=None, inplace=True), None),
-        type(None),
+        assert_type(
+            pd.Series([1, 2, 3]).rename(index=None, inplace=True), "pd.Series[int]"
+        ),
+        pd.Series,
+        np.integer,
     )
     # TODO this should not raise an error, the lambda is matched with Hashable
     # check(