GH1139 PR Feedback

Author: loicdiridollou

pandas-stubs/core/series.pyi

@@ -1041,6 +1041,17 @@ class Series(IndexOpsMixin[S1], NDFrame):
         broadcast_axis: AxisIndex | None = ...,
     ) -> tuple[Series, Series]: ...
     @overload
+    def rename(
+        self,
+        index: None = ...,
+        *,
+        axis: Axis | None = ...,
+        copy: bool = ...,
+        inplace: Literal[True],
+        level: Level | None = ...,
+        errors: IgnoreRaise = ...,
+    ) -> None: ...
+    @overload
     def rename(
         self,
         index: Hashable,

tests/test_series.py

@@ -1237,6 +1237,10 @@ def add1(x: int) -> int:
         assert_type(pd.Series([1, 2, 3]).rename({1: 4, 2: 5}, inplace=True), None),
         type(None),
     )
+    check(
+        assert_type(pd.Series([1, 2, 3]).rename(index=None, inplace=True), None),
+        type(None),
+    )
     # TODO this should not raise an error, the lambda is matched with Hashable
     # check(
     #     assert_type(pd.Series([1, 2, 3]).rename(lambda x: x**2, inplace=True), None), type(None)