Skip to content

Commit 40cf35d

Browse files
committed
Do not export cell objects.
1 parent 6ce1e36 commit 40cf35d

File tree

4 files changed

+6
-44
lines changed

4 files changed

+6
-44
lines changed

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/nodes/cell/CellSupplier.java

Lines changed: 0 additions & 35 deletions
This file was deleted.

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/nodes/cell/WriteCellVarNode.java

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/*
2-
* Copyright (c) 2017, 2018, Oracle and/or its affiliates.
2+
* Copyright (c) 2017, 2019, Oracle and/or its affiliates.
33
* Copyright (c) 2013, Regents of the University of California
44
*
55
* All rights reserved.
@@ -27,6 +27,7 @@
2727

2828
import com.oracle.graal.python.builtins.objects.cell.PCell;
2929
import com.oracle.graal.python.nodes.expression.ExpressionNode;
30+
import com.oracle.graal.python.nodes.function.FunctionRootNode;
3031
import com.oracle.graal.python.nodes.statement.StatementNode;
3132
import com.oracle.truffle.api.dsl.Specialization;
3233
import com.oracle.truffle.api.frame.FrameSlot;
@@ -36,10 +37,10 @@
3637
@NodeInfo(shortName = "write_cellvar")
3738
public abstract class WriteCellVarNode extends StatementNode {
3839
private int cellIndex = -1;
39-
private final CellSupplier cellSupplier;
40+
private final FunctionRootNode cellSupplier;
4041
@Child private ExpressionNode readNode;
4142

42-
WriteCellVarNode(ExpressionNode readNode, CellSupplier cellSupplier, String identifier) {
43+
WriteCellVarNode(ExpressionNode readNode, FunctionRootNode cellSupplier, String identifier) {
4344
this.readNode = readNode;
4445
this.cellSupplier = cellSupplier;
4546

@@ -53,7 +54,7 @@ public abstract class WriteCellVarNode extends StatementNode {
5354
}
5455
}
5556

56-
public static WriteCellVarNode create(ExpressionNode readNode, CellSupplier cellSupplier, String identifier) {
57+
public static WriteCellVarNode create(ExpressionNode readNode, FunctionRootNode cellSupplier, String identifier) {
5758
return WriteCellVarNodeGen.create(readNode, cellSupplier, identifier);
5859
}
5960

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/nodes/function/FunctionRootNode.java

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,6 @@
3030
import com.oracle.graal.python.builtins.objects.function.PArguments;
3131
import com.oracle.graal.python.builtins.objects.function.Signature;
3232
import com.oracle.graal.python.nodes.PClosureFunctionRootNode;
33-
import com.oracle.graal.python.nodes.cell.CellSupplier;
3433
import com.oracle.graal.python.nodes.expression.ExpressionNode;
3534
import com.oracle.graal.python.parser.ExecutionCellSlots;
3635
import com.oracle.graal.python.runtime.PythonContext;
@@ -50,7 +49,7 @@
5049
/**
5150
* RootNode of a Python Function body. It is invoked by a CallTarget.
5251
*/
53-
public class FunctionRootNode extends PClosureFunctionRootNode implements CellSupplier {
52+
public class FunctionRootNode extends PClosureFunctionRootNode {
5453
private final ContextReference<PythonContext> contextRef;
5554
private final PCell[] cells;
5655
private final ExecutionCellSlots executionCellSlots;
@@ -88,12 +87,10 @@ public String getName() {
8887
return functionName;
8988
}
9089

91-
@Override
9290
public PCell[] getCells() {
9391
return cells;
9492
}
9593

96-
@Override
9794
public FrameSlot[] getCellVarSlots() {
9895
return cellVarSlots;
9996
}

mx.graalpython/copyrights/overrides

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -383,7 +383,6 @@ graalpython/com.oracle.graal.python/src/com/oracle/graal/python/nodes/argument/p
383383
graalpython/com.oracle.graal.python/src/com/oracle/graal/python/nodes/call/CallDispatchNode.java,zippy.copyright
384384
graalpython/com.oracle.graal.python/src/com/oracle/graal/python/nodes/call/InvokeNode.java,zippy.copyright
385385
graalpython/com.oracle.graal.python/src/com/oracle/graal/python/nodes/call/PythonCallNode.java,zippy.copyright
386-
graalpython/com.oracle.graal.python/src/com/oracle/graal/python/nodes/cell/CellSupplier.java,zippy.copyright
387386
graalpython/com.oracle.graal.python/src/com/oracle/graal/python/nodes/cell/ReadLocalCellNode.java,zippy.copyright
388387
graalpython/com.oracle.graal.python/src/com/oracle/graal/python/nodes/cell/WriteCellVarNode.java,zippy.copyright
389388
graalpython/com.oracle.graal.python/src/com/oracle/graal/python/nodes/cell/WriteLocalCellNode.java,zippy.copyright

0 commit comments

Comments
 (0)