Improve function object creation for fast path.

Author: fangerer

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/objects/function/PFunction.java

@@ -50,8 +50,8 @@ public class PFunction extends PythonObject {
     private static final Object[] EMPTY_DEFAULTS = new Object[0];
     private final String name;
     private final String enclosingClassName;
-    private final Assumption codeStableAssumption = Truffle.getRuntime().createAssumption();
-    private final Assumption defaultsStableAssumption = Truffle.getRuntime().createAssumption();
+    private final Assumption codeStableAssumption;
+    private final Assumption defaultsStableAssumption;
     private final PythonObject globals;
     private final PCell[] closure;
     private final boolean isStatic;
@@ -65,11 +65,11 @@ public PFunction(LazyPythonClass clazz, String name, String enclosingClassName,
 
     public PFunction(LazyPythonClass clazz, String name, String enclosingClassName, RootCallTarget callTarget, PythonObject globals, Object[] defaultValues, PKeyword[] kwDefaultValues,
                     PCell[] closure) {
-        this(clazz, name, enclosingClassName, callTarget, globals, defaultValues, kwDefaultValues, closure, null);
+        this(clazz, name, enclosingClassName, callTarget, globals, defaultValues, kwDefaultValues, closure, null, Truffle.getRuntime().createAssumption(), Truffle.getRuntime().createAssumption());
     }
 
     public PFunction(LazyPythonClass clazz, String name, String enclosingClassName, RootCallTarget callTarget, PythonObject globals, Object[] defaultValues, PKeyword[] kwDefaultValues,
-                    PCell[] closure, WriteAttributeToDynamicObjectNode writeAttrNode) {
+                    PCell[] closure, WriteAttributeToDynamicObjectNode writeAttrNode, Assumption codeStableAssumption, Assumption defaultsStableAssumption) {
         super(clazz);
         this.name = name;
         this.code = new PCode(PythonBuiltinClassType.PCode, callTarget);
@@ -79,6 +79,8 @@ public PFunction(LazyPythonClass clazz, String name, String enclosingClassName,
         this.defaultValues = defaultValues == null ? EMPTY_DEFAULTS : defaultValues;
         this.kwDefaultValues = kwDefaultValues == null ? PKeyword.EMPTY_KEYWORDS : kwDefaultValues;
         this.closure = closure;
+        this.codeStableAssumption = codeStableAssumption;
+        this.defaultsStableAssumption = defaultsStableAssumption;
         addDefaultConstants(writeAttrNode, getStorage(), name, enclosingClassName);
     }
 

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/nodes/function/FunctionDefinitionNode.java

@@ -38,7 +38,10 @@
 import com.oracle.graal.python.parser.ExecutionCellSlots;
 import com.oracle.graal.python.runtime.PythonContext;
 import com.oracle.graal.python.runtime.object.PythonObjectFactory;
+import com.oracle.truffle.api.Assumption;
+import com.oracle.truffle.api.CompilerDirectives;
 import com.oracle.truffle.api.RootCallTarget;
+import com.oracle.truffle.api.Truffle;
 import com.oracle.truffle.api.TruffleLanguage.ContextReference;
 import com.oracle.truffle.api.frame.VirtualFrame;
 import com.oracle.truffle.api.nodes.ExplodeLoop;
@@ -57,6 +60,9 @@ public class FunctionDefinitionNode extends ExpressionDefinitionNode {
     @Child private WriteAttributeToDynamicObjectNode writeNameNode = WriteAttributeToDynamicObjectNode.create();
     @Child private PythonObjectFactory factory = PythonObjectFactory.create();
 
+    private final Assumption sharedCodeStableAssumption = Truffle.getRuntime().createAssumption("shared code stable assumption");
+    private final Assumption sharedDefaultsStableAssumption = Truffle.getRuntime().createAssumption("shared defaults stable assumption");
+
     public FunctionDefinitionNode(String functionName, String enclosingClassName, ExpressionNode doc, ExpressionNode[] defaults, KwDefaultExpressionNode[] kwDefaults,
                     RootCallTarget callTarget,
                     DefinitionCellSlots definitionCellSlots, ExecutionCellSlots executionCellSlots) {
@@ -94,7 +100,26 @@ public Object execute(VirtualFrame frame) {
         Object[] defaultValues = computeDefaultValues(frame);
         PKeyword[] kwDefaultValues = computeKwDefaultValues(frame);
         PCell[] closure = getClosureFromGeneratorOrFunctionLocals(frame);
-        return withDocString(frame, factory().createFunction(functionName, enclosingClassName, callTarget, PArguments.getGlobals(frame), defaultValues, kwDefaultValues, closure, writeNameNode));
+        Assumption codeStableAssumption;
+        Assumption defaultsStableAssumption;
+        if (CompilerDirectives.inCompiledCode()) {
+            codeStableAssumption = getSharedCodeStableAssumption();
+            defaultsStableAssumption = getSharedDefaultsStableAssumption();
+        } else {
+            codeStableAssumption = Truffle.getRuntime().createAssumption();
+            defaultsStableAssumption = Truffle.getRuntime().createAssumption();
+        }
+        return withDocString(frame, factory().createFunction(functionName, enclosingClassName, callTarget, PArguments.getGlobals(frame), defaultValues, kwDefaultValues, closure, writeNameNode,
+                        codeStableAssumption, defaultsStableAssumption));
+
+    }
+
+    private Assumption getSharedDefaultsStableAssumption() {
+        return sharedDefaultsStableAssumption;
+    }
+
+    private Assumption getSharedCodeStableAssumption() {
+        return sharedCodeStableAssumption;
     }
 
     @ExplodeLoop

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/runtime/object/PythonObjectFactory.java

@@ -123,6 +123,7 @@
 import com.oracle.graal.python.runtime.sequence.storage.LongSequenceStorage;
 import com.oracle.graal.python.runtime.sequence.storage.SequenceStorage;
 import com.oracle.graal.python.runtime.sequence.storage.SequenceStorageFactory;
+import com.oracle.truffle.api.Assumption;
 import com.oracle.truffle.api.RootCallTarget;
 import com.oracle.truffle.api.TruffleFile;
 import com.oracle.truffle.api.TruffleLanguage.ContextReference;
@@ -365,8 +366,9 @@ public PFunction createFunction(String name, String enclosingClassName, RootCall
     }
 
     public PFunction createFunction(String name, String enclosingClassName, RootCallTarget callTarget, PythonObject globals, Object[] defaultValues, PKeyword[] kwDefaultValues,
-                    PCell[] closure, WriteAttributeToDynamicObjectNode writeAttrNode) {
-        return trace(new PFunction(PythonBuiltinClassType.PFunction, name, enclosingClassName, callTarget, globals, defaultValues, kwDefaultValues, closure, writeAttrNode));
+                    PCell[] closure, WriteAttributeToDynamicObjectNode writeAttrNode, Assumption codeStableAssumption, Assumption defaultsStableAssumption) {
+        return trace(new PFunction(PythonBuiltinClassType.PFunction, name, enclosingClassName, callTarget, globals, defaultValues, kwDefaultValues, closure, writeAttrNode, codeStableAssumption,
+                        defaultsStableAssumption));
     }
 
     public PBuiltinFunction createBuiltinFunction(String name, LazyPythonClass type, int numDefaults, RootCallTarget callTarget) {