feat: Use annotation to skip ApiServer LoadBalancer reconciliation #417
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your pull request and welcome to our community! To contribute, please sign the Oracle Contributor Agreement (OCA).
To sign the OCA, please create an Oracle account and sign the OCA in Oracle's Contributor Agreement Application. When signing the OCA, please provide your GitHub username. After signing the OCA and getting an OCA approval from Oracle, this PR will be automatically updated. If you are an Oracle employee, please make sure that you are a member of the main Oracle GitHub organization, and your membership in this organization is public. |
oracle-contributor-agreement
bot
added
the
OCA Required
|
Thank you for signing the OCA. |
oracle-contributor-agreement
bot
added
OCA Verified
Signed-off-by: Javi Polo <[email protected]>
javipolo
force-pushed
the
skip_apiserver_management_annotation
branch
from
2b5beb9 to
1f3cffa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
When trying to import a cluster that is already running and fully functional, we want API LoadBalancer to be unmanaged, the same way as
SkipNetworkManagementdoes for other networkingIf using the annotation suggested by the documentation:
CAPOCI does nothing and the
Clusterresource never gets fullyProvisionedin CAPII think a more elegant solution to my PR would be to include an
SkipApiserverManagementtoSpec.NetworkSpec.APIServerLB, but I thought it would be less intrusive to do it as an annotationFeel free to suggest or change the proposed solution
The context of all this is trying to enable cluster-autoscaler in cluster already running in Oracle Cloud, that was not deployed via CAPI
You can find the whole PoC in https://github.com/javipolo/openshift-oci-capi-autoscaling