Add node pool recycling options

Author: shyamradhakrishnan

cloud/scope/managed_machine_pool.go

@@ -20,7 +20,6 @@ import (
 	"context"
 	"encoding/json"
 	"fmt"
-	"github.com/oracle/cluster-api-provider-oci/cloud/util"
 	"reflect"
 	"sort"
 	"strconv"
@@ -699,7 +698,7 @@ func (m *ManagedMachinePoolScope) UpdateNodePool(ctx context.Context, pool *oke.
 			}
 		}
 		if recycleConfig != nil && len(nodeConfigDetails.PlacementConfigs) != 0 {
-			m.Logger.V(util.LogLevelWarn).Info("Placement configuration has been changed in the update, " +
+			m.Logger.V(LogLevelWarn).Info("Placement configuration has been changed in the update, " +
 				"hence node pool recycling configuration will not be sent with the update request")
 		}
 		if spec.NodeEvictionNodePoolSettings != nil {

cloud/scope/util.go

@@ -20,6 +20,10 @@ import (
 	infrastructurev1beta2 "github.com/oracle/cluster-api-provider-oci/api/v1beta2"
 )
 
+const (
+	LogLevelWarn = 3
+)
+
 // GetNsgNamesFromId returns the names of the NSGs with the provided IDs
 func GetNsgNamesFromId(ids []string, nsgs []*infrastructurev1beta2.NSG) []string {
 	names := make([]string, 0)

cloud/util/util.go

@@ -34,10 +34,6 @@ import (
 	"sigs.k8s.io/controller-runtime/pkg/client"
 )
 
-const (
-	LogLevelWarn = 3
-)
-
 // GetClusterIdentityFromRef returns the OCIClusterIdentity referenced by the OCICluster.
 func GetClusterIdentityFromRef(ctx context.Context, c client.Client, ociClusterNamespace string, ref *corev1.ObjectReference) (*infrastructurev1beta2.OCIClusterIdentity, error) {
 	identity := &infrastructurev1beta2.OCIClusterIdentity{}