Add node pool recycling options

Author: shyamradhakrishnan

cloud/scope/managed_machine_pool.go

@@ -20,6 +20,7 @@ import (
 	"context"
 	"encoding/json"
 	"fmt"
+	"github.com/oracle/cluster-api-provider-oci/cloud/util"
 	"reflect"
 	"sort"
 	"strconv"
@@ -697,6 +698,10 @@ func (m *ManagedMachinePoolScope) UpdateNodePool(ctx context.Context, pool *oke.
 				MaximumUnavailable:   recycleConfig.MaximumUnavailable,
 			}
 		}
+		if recycleConfig != nil && len(nodeConfigDetails.PlacementConfigs) != 0 {
+			m.Logger.V(util.LogLevelWarn).Info("Placement configuration has been changed in the update, " +
+				"hence node pool recycling configuration will not be sent with the update request")
+		}
 		if spec.NodeEvictionNodePoolSettings != nil {
 			nodePoolDetails.NodeEvictionNodePoolSettings = &oke.NodeEvictionNodePoolSettings{
 				EvictionGraceDuration:           spec.NodeEvictionNodePoolSettings.EvictionGraceDuration,

cloud/util/util.go

@@ -34,6 +34,10 @@ import (
 	"sigs.k8s.io/controller-runtime/pkg/client"
 )
 
+const (
+	LogLevelWarn = 3
+)
+
 // GetClusterIdentityFromRef returns the OCIClusterIdentity referenced by the OCICluster.
 func GetClusterIdentityFromRef(ctx context.Context, c client.Client, ociClusterNamespace string, ref *corev1.ObjectReference) (*infrastructurev1beta2.OCIClusterIdentity, error) {
 	identity := &infrastructurev1beta2.OCIClusterIdentity{}

exp/api/v1beta2/ocimanagedmachinepool_webhook.go

@@ -18,10 +18,11 @@ package v1beta2
 
 import (
 	"fmt"
+	"reflect"
+
 	apierrors "k8s.io/apimachinery/pkg/api/errors"
 	"k8s.io/apimachinery/pkg/runtime"
 	"k8s.io/apimachinery/pkg/util/validation/field"
-	"reflect"
 	"sigs.k8s.io/cluster-api/util/version"
 	ctrl "sigs.k8s.io/controller-runtime"
 	"sigs.k8s.io/controller-runtime/pkg/webhook"